Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add category gallery with featured projects and category-specific sub-galleries #406

Merged
merged 18 commits into from
Jul 30, 2024
Merged

Add category gallery with featured projects and category-specific sub-galleries #406

merged 18 commits into from
Jul 30, 2024

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Jul 27, 2024 •
edited
Loading

Adds a new and improved category gallery based homepage with featured projects and category-specific subgalleries.

TODO:

  • Add favorites as a section and pin order of the categories
  • Add visual separator between favorites and other categories
  • Combine related categories with small number of examples (finance, economics)
  • Hard code the valid categories
  • change 'favorites' to 'featured'
  • Add side nav with section pages as second level
  • Add external link to holoviz.org in center nav bar
  • Add filtering based on tags
  • Make cards reflow based on filter label selection
  • Add how to contribute to intro of homepage
  • Create issue for grabbing categories from individual projects instead of tags.yml
  • Create issue for future PR to add validation check for existence of category

Before

image

After

GMT20240730-221306_Clip_Demetris.Roumis.s.Clip.07_30_2024.mp4

@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis changed the title WIP category gallery Add category gallery with featured projects and category-specific sub-galleries Jul 27, 2024
@droumis droumis marked this pull request as ready for review July 27, 2024 07:38
@droumis droumis requested a review from maximlt July 27, 2024 07:38
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis changed the title Add category gallery with featured projects and category-specific sub-galleries [WIP] Add category gallery with featured projects and category-specific sub-galleries Jul 29, 2024
@droumis droumis added the wip Work in progress; do not merge label Jul 29, 2024
@droumis droumis changed the title [WIP] Add category gallery with featured projects and category-specific sub-galleries Add category gallery with featured projects and category-specific sub-galleries Jul 29, 2024
@droumis droumis removed the wip Work in progress; do not merge label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis
Copy link
Contributor Author

droumis commented Jul 30, 2024

Not sure if this should be the main homepage redirect or not yet.` Discussed this with Maxime. We decided to just replace the main existing gallery with a categorized gallery view.

@droumis
Copy link
Contributor Author

droumis commented Jul 30, 2024

@maximlt gave me the green light to merge when ready

@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis mentioned this pull request Jul 30, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis merged commit 80a71b3 into main Jul 30, 2024
7 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt deleted the cat_gallery branch October 8, 2024 09:55
@maximlt maximlt mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximlt maximlt Awaiting requested review from maximlt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@droumis