Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dask DataFrame plot test #1131

Merged
merged 15 commits into from
Oct 6, 2023
Merged

Add Dask DataFrame plot test #1131

merged 15 commits into from
Oct 6, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 7, 2023

Continue the work done in #1129 by adding simple plotting tests of dask.DataFrame and dask.Series.

I discovered a small bug that kde and density did error out because pd.melt was used.

Which means that something like this errors out on main:

import dask.dataframe as dd
import hvplot.pandas
import pandas as pd

y = ["A", "B", "C", "D"]
kind = "density"
df = dd.from_pandas(pd._testing.makeDataFrame(), npartitions=2)
df.hvplot(y=y, kind=kind)

@maximlt maximlt added this to the 0.9.0 milestone Sep 11, 2023
@maximlt
Copy link
Member

maximlt commented Sep 28, 2023

LGTM! I've added dask to the core test dependencies, its support should definitely be tested as often as possible.

It took me a while before I figured out this PR wasn't targeting main, once the branch it targets is merged I will point it to main so the commit history is as expected.

@hoxbro
Copy link
Member Author

hoxbro commented Sep 29, 2023

LGTM! I've added dask to the core test dependencies, its support should definitely be tested as often as possible.

Fine by me.

It took me a while before I figured out this PR wasn't targeting main, once the branch it targets is merged I will point it to main so the commit history is as expected.

Yeah, didn't want the merge conflict, so based in on the Polars PR. This should automatic be re-targeted when Polars Pr are merged. Though, something like this could be needed git merge main --strategy-option ours.

@maximlt maximlt self-requested a review October 2, 2023 08:34
Base automatically changed from polars_support_simple to main October 2, 2023 14:34
@maximlt maximlt merged commit bffa369 into main Oct 6, 2023
7 checks passed
@maximlt maximlt deleted the dask_plot_test branch October 6, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants