Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gridded + geographic + auto refresh_plot for explorer #1141

Merged
merged 46 commits into from
Oct 12, 2023
Merged

Support gridded + geographic + auto refresh_plot for explorer #1141

merged 46 commits into from
Oct 12, 2023

Conversation

ahuang11
Copy link
Collaborator

Much to fix and figure out, but here's a MVP!

Screen.Recording.2023-09-15.at.5.31.26.PM.mov

@jbednar
Copy link
Member

jbednar commented Sep 18, 2023

Looks great so far!!!

@philippjfr
Copy link
Member

Might be nice to use groups for the kind Select widget and then put grid based plot types first.

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Sep 19, 2023 •
edited
Loading

Ok I think it's in a decent spot.

demo.mp4

Thinking of adding a CLI tomorrow:
hvplot air.nc -x lon -y lat which triggers `hvplot.explorer(xr.open_dataset("air.nc"), x="lon", y="lat")

@maximlt
Copy link
Member

maximlt commented Sep 19, 2023

Nice progress! If you intend to add a CLI please do it in another PR.

@jbednar
Copy link
Member

jbednar commented Sep 19, 2023

Looks great. I think most of the geo features need to be on top of the data, not behind it, so that they will work with raster plots:
image
Here you can see the coastlines only because of zooming out past the data, which most people wouldn't do. But "land" might have to be in the background so it doesn't obscure data. Tricky.

@ahuang11
Copy link
Collaborator Author

Fixed the overlaying underlaying here.
#1145

@ahuang11 ahuang11 marked this pull request as ready for review September 20, 2023 00:22
hoxbro
hoxbro reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a thorough review, but I left some comments.

I would also love to see some kind of docs.

hvplot/ui.py Outdated Show resolved Hide resolved
hvplot/ui.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 changed the title Step towards implementing xarray explorer Step towards implementing xarray explorer + geo Sep 21, 2023
This was referenced Sep 21, 2023
Open
Open
@ahuang11 ahuang11 added this to the 0.9.0 milestone Sep 27, 2023
ahuang11 and others added 9 commits September 27, 2023 14:30
@ahuang11 @hoxbro
Support plots that use by with rasterize with hv.ImageStack (#1132)
2cd9a10 
* WIP overlaying rasterized

* Clean up

* Add rasterize to check for categorical

* Add test

* Add version check

* Update hvplot/converter.py

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>

---------

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@hoxbro @ahuang11
Handle wkt format (#1092)
ba9eb92
@ahuang11
Add version check for test (#1144)
98c2612 
* Add version check for test

* commit
@maximlt @ahuang11
Param 2: don't call param.objects() before super().__init__ in the …
8923efe 
…explorer (#1146)

* call param.objects() after super().__init__

* add tests

* update the docs

* update error message
@philippjfr @hoxbro @ahuang11
Add autorange option (#1128)
4a9b8d2 
* Add autorange option

* Add small documentation about autorange

---------

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@philippjfr @hoxbro @ahuang11
Expose timeseries downsampling as an option (#1127)
dcbf12a 
* Expose timeseries downsampling as an option

* Add small documentation about downsample

---------

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@hoxbro @ahuang11
Fixing conda package build (#1148)
13ef34c
@ahuang11
Step towards implementing xarray explorer
99ec889
@ahuang11
Group by kinds and add auto refresh
9180fec
@ahuang11 ahuang11 mentioned this pull request Sep 28, 2023
Closed
@ahuang11 ahuang11 changed the title Step towards implementing xarray explorer + geo Support gridded + geographic + auto refresh_plot for explorer Oct 1, 2023
@hoxbro hoxbro mentioned this pull request Oct 2, 2023
Closed
2 tasks
@maximlt maximlt mentioned this pull request Oct 3, 2023
Merged
@ahuang11
Copy link
Collaborator Author

ahuang11 commented Oct 5, 2023

Can we merge this?

@maximlt
Copy link
Member

maximlt commented Oct 5, 2023

@hoxbro was assigned as a reviewer on this PR, he'll let you know if it's ready to be merged :)

@maximlt
Copy link
Member

maximlt commented Oct 12, 2023 •
edited
Loading

  • I believe your IDE formatted some files by mistake, I tried to revert that
  • Nit pick again but I also prefer when quotes are consistent, reverted to single quotes
  • I re-implemented the "refresh plot" feature so it's now available at the bottom of the explorer, in what is meant to be/become a status bar. Got some inspiration from the Perspective viewer, and motivated by the fact I found it was weird to have this button part of each Control pane.
  • I've reviewed (although not in great details) the Xarray+Geo changes, which seemed good to me.
  • I've reduced the min_height to 400 (updated from 300 to 600 in this PR), assuming 600 would be to high for users on smaller screens.

Thanks again @ahuang11 for taking this over!

@maximlt maximlt merged commit 2abfb28 into main Oct 12, 2023
7 checks passed
@maximlt maximlt deleted the hvplot_gridded_explorer branch October 12, 2023 13:18
@maximlt maximlt mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximlt maximlt maximlt approved these changes

@hoxbro hoxbro Awaiting requested review from hoxbro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ahuang11 @jbednar @philippjfr @maximlt @hoxbro