Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set bin_range if shared_axes=False #1391

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Aug 7, 2024

Closes #1100
image

@ahuang11 ahuang11 added the type: bug Something isn't working label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (6c96c7e) to head (b63d976).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   87.39%   88.88%   +1.49%     
==========================================
  Files          50       51       +1     
  Lines        7490     7514      +24     
==========================================
+ Hits         6546     6679     +133     
+ Misses        944      835     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hvplot/converter.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 marked this pull request as ready for review August 7, 2024 18:20
@ahuang11 ahuang11 merged commit 6f245d4 into main Aug 7, 2024
9 checks passed
@ahuang11 ahuang11 deleted the fix_hist_shared_axes branch August 7, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared_axes=False not working for hvplot.hist()
2 participants