Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/847 support multiple sort criterias #875

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

MichaelVonB
Copy link
Contributor

Sort parameter now accepts a list of String instead. Old api (single string) is kept and marked as deprecated.
Fixes #847

@MichaelVonB MichaelVonB linked an issue Sep 29, 2023 that may be closed by this pull request
@MichaelVonB MichaelVonB added this to the 3.16 milestone Sep 29, 2023
view/view-api/src/main/kotlin/sort/Sorter.kt Outdated Show resolved Hide resolved
view/view-api/src/main/kotlin/sort/Sorter.kt Outdated Show resolved Hide resolved
view/view-api/src/main/kotlin/sort/Sorter.kt Outdated Show resolved Hide resolved
view/view-api/src/main/kotlin/sort/Sorter.kt Outdated Show resolved Hide resolved
@zambrovski
Copy link
Member

Looks generally good, could you fix the minor issues, please?

@MichaelVonB
Copy link
Contributor Author

Should be done. Let me know if there is anything else

@zambrovski zambrovski merged commit 02ca8cb into develop Oct 10, 2023
7 checks passed
@zambrovski zambrovski deleted the feature/847-support-multiple-sort-criterias branch October 10, 2023 10:57
@zambrovski zambrovski modified the milestones: 3.16, 3.19 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple sort criterias
2 participants