Merge pull request #41 from mohamed-barakat/devel

comply with FinSetsForCAP v2022.05-01
homalg-project · May 16, 2022 · 2a8bbf4 · 2a8bbf4
2 parents 7662319 + 3fed3a5
commit 2a8bbf4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/PackageInfo.g b/PackageInfo.g
@@ -10,13 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "FinGSetsForCAP",
 Subtitle := "The elementary topos of (skeletal) finite G-sets",
-Version := Maximum( [
-                   "2018.09-17", ## Mohamed's version
-                   ## this line prevents merge conflicts
-                   "2017.05-26", ## Julia's version
-                   ## this line prevents merge conflicts
-                   "2021.05-01", ## Fabian's version
-                   ] ),
+Version := "2021.05-02",
 
 Date := Concatenation( "01/", ~.Version{[ 6, 7 ]}, "/", ~.Version{[ 1 .. 4 ]} ),
 License := "GPL-2.0-or-later",
@@ -109,7 +103,7 @@ Dependencies := rec(
                    [ "Toposes", ">= 2021.03-01" ],
                    ],
   SuggestedOtherPackages := [
-                   [ "FinSetsForCAP", ">= 2021.03-01" ],
+                   [ "FinSetsForCAP", ">= 2022.05-01" ],
                    ],
   ExternalConditions := [ ],
 ),

diff --git a/gap/EndAsEqualizer.gi b/gap/EndAsEqualizer.gi
@@ -11,12 +11,10 @@ InstallGlobalFunction( EndAsEqualizer, function ( C, HomC, ForgetfulFunctor, Ind
         local s, t, L, i, phi;
         s := Length( S );
         t := Length( T );
-        L := ListWithIdenticalEntries( s, 1 );
-        # lists start with entry 1, we want to start at 0 and add back 1 later
-        int := int - 1;
+        L := ListWithIdenticalEntries( s, 0 );
         i := 1;
         while int <> 0 do
-            L[ i ] := ( int mod t ) + 1;
+            L[ i ] := ( int mod t );
             int := QuoInt( int, t );
             i := i + 1;
         od;
@@ -42,10 +40,10 @@ InstallGlobalFunction( EndAsEqualizer, function ( C, HomC, ForgetfulFunctor, Ind
 
         int := 0;
         for i in [ 0 .. ( s - 1 ) ] do
-            int := int + ( imgs[ i + 1 ] - 1 ) * t^i;
+            int := int + imgs[ i + 1 ] * t^i;
         od;
 
-        return int + 1;
+        return int;
     end;
 
     HomFinSetsSkeletal := function ( S, T )

diff --git a/gap/ForgetfulFunctorSkeletalGSets.gi b/gap/ForgetfulFunctorSkeletalGSets.gi
@@ -79,7 +79,7 @@ InstallMethod( ForgetfulFunctorSkeletalFinGSets,
                 j := imgs[i][l][3];
 
                 for h in RightCosets( group, U_i ) do
-                    Add( Set_imgs, OffsetOfCofactorInTarget( r, j ) + OffsetOfElementInCofactor( g * Representative( h ), j ) );
+                    Add( Set_imgs, -1 + OffsetOfCofactorInTarget( r, j ) + OffsetOfElementInCofactor( g * Representative( h ), j ) );
                 od;
             od;
         od;