Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.11+ #784

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Require Python 3.11+ #784

merged 2 commits into from
Jan 16, 2024

Conversation

emontnemery
Copy link
Collaborator

Run tests with Python 3.11 and update Readme to mention Python 3.11+ is required

@emontnemery emontnemery changed the title Run tests with Python 3.11 Require Python 3.11+ Jan 16, 2024
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set python_requires=">=3.11" in setup.py too.

@@ -17,6 +17,7 @@
include_package_data=True,
platforms="any",
install_requires=list(val.strip() for val in open("requirements.txt")),
Copy link
Contributor

@MartinHjelmare MartinHjelmare Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: It's not good practice to set the production requirements the same way as the development requirements. I recommend pinning the development requirements strictly in requirements files (or an optional list in pyproject.toml) and have as forgiving pinning for the production as possible directly in setup.py (or pyproject.toml).

It would also be good to change to pyproject.toml at some point.

@emontnemery emontnemery merged commit 0a1dc7e into master Jan 16, 2024
1 check passed
@emontnemery emontnemery deleted the test_python_3_11 branch January 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants