Build hassfest docker image and pushlish it on beta/stable releases #124706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
approved these changes
Aug 27, 2024
emontnemery
approved these changes
Aug 28, 2024
edenhaus
changed the title
ludeeus
reviewed
Aug 28, 2024
edenhaus
force-pushed
the
edenhaus-hassfest-docker-fix
branch
from
8483b76
to
04bb36a
Compare
joostlek
changed the title
|
Test run successfully: https://github.com/home-assistant/core/actions/runs/10597687168 |
edenhaus
changed the title
edenhaus
changed the title
emontnemery
previously requested changes
Aug 28, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
approved these changes
Aug 28, 2024
ludeeus
reviewed
Aug 29, 2024
| run: docker run --rm -v ${{ github.workspace }}/homeassistant:/github/workspace/homeassistant ${{ env.HASSFEST_IMAGE_TAG }} --core-integrations-path=/github/workspace/homeassistant/components | ||
|
|
||
| - name: Push Docker image | ||
| if: needs.init.outputs.channel != 'dev' && needs.init.outputs.publish == 'true' |
There was a problem hiding this comment.
I think we did not target dev for this because there was no ":dev" tag.
As we are now inside the builder that also builds dev, is there still a reason to not update this on dev?
As this is used by custom integration authors, its better to get a new version of hassfest out to them as soon as possible right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Build hassfest docker images when build workflow runs and test that the hassfest docker image successfully validates core.
On beta/stable releases the hassfest docker image will also be publish
Required for home-assistant/actions#111
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: