Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cypress M8 USB serial driver for all targets #3693

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Nov 22, 2024

Build cypress_m8 driver as module for all targets - some of them had it in their base defconfig while some not. It is required e.g. for UPB PIM (Powerline Interface Module).

Fixes #3690

Summary by CodeRabbit

  • New Features

    • Added support for Cypress M8 USB serial devices, enhancing compatibility with additional USB hardware.
  • Improvements

    • Expanded USB-related configurations to improve functionality and support for various USB devices.
    • Updated multimedia subsystem options for better video and audio processing capabilities.

Build cypress_m8 driver as module for all targets - some of them had it in
their base defconfig while some not. It is required e.g. for UPB PIM (Powerline
Interface Module).

Fixes #3690
@sairon sairon added os linux Linux kernel related issue labels Nov 22, 2024
@sairon sairon requested a review from agners November 22, 2024 11:48
Copy link

coderabbitai bot commented Nov 22, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request introduce a new configuration option for the Cypress M8 USB serial driver in two kernel configuration files. The CONFIG_USB_SERIAL_CYPRESS_M8 option is enabled in both device-support.config and kernel-arm64-rockchip.config, expanding support for USB serial devices. The modifications include enabling additional USB-related configurations without altering existing entries significantly, ensuring that the overall structure of the configuration files remains intact.

Changes

File Path Change Summary
buildroot-external/kernel/v6.6.y/device-support.config Added CONFIG_USB_SERIAL_CYPRESS_M8=m
buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config Updated CONFIG_USB_SERIAL_CYPRESS_M8 from commented out to m

Assessment against linked issues

Objective Addressed Explanation
Enable driver support for UPB PIM (USB) (#3690)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b288cd2 and 75fd9d0.

📒 Files selected for processing (2)
  • buildroot-external/kernel/v6.6.y/device-support.config (1 hunks)
  • buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config (0 hunks)
💤 Files with no reviewable changes (1)
  • buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config
🔇 Additional comments (2)
buildroot-external/kernel/v6.6.y/device-support.config (2)

16-16: LGTM! The change correctly enables the Cypress M8 driver.

The addition of CONFIG_USB_SERIAL_CYPRESS_M8=m is well-placed within the USB serial drivers section and follows the established pattern of building drivers as modules. This change will enable the driver across all targets while maintaining consistency with the existing configuration structure.


16-16: Verify UPB PIM detection with the new driver.

Let's confirm this change resolves the UPB PIM detection issue mentioned in #3690.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit d57e507 into dev Nov 22, 2024
3 checks passed
@sairon sairon deleted the enable-cypress-m8-usb-serial branch November 22, 2024 12:56
sairon added a commit that referenced this pull request Nov 22, 2024
Build cypress_m8 driver as module for all targets - some of them had it in
their base defconfig while some not. It is required e.g. for UPB PIM (Powerline
Interface Module).

Fixes #3690

(cherry picked from commit d57e507)
@sairon sairon mentioned this pull request Nov 22, 2024
@sairon sairon mentioned this pull request Dec 3, 2024
This was referenced Dec 17, 2024
jens-maus added a commit to jens-maus/RaspberryMatic that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed linux Linux kernel related issue os
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPB PIM (USB) no drivers in HAOS 13.2 x86-64
2 participants