Add Hailo PCIe driver and firmware for Yellow #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PCIe card from the RPi AI Kit (and probably other M.2 cards using the Hailo-8 chip) can be used on Yellow - the driver initializes correctly and creates a /dev/hailo0 device on Yellow both with CM4 and CM5.
📝 WalkthroughWalkthroughThe changes in this pull request involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Buildroot
participant RaspberryPi
User->>Buildroot: Request build with yellow_defconfig
Buildroot->>RaspberryPi: Include HAILO8 firmware and PCI support
RaspberryPi-->>Buildroot: Build complete
Buildroot-->>User: Return build output
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
buildroot-external/configs/yellow_defconfig(1 hunks)
🔇 Additional comments (2)
buildroot-external/configs/yellow_defconfig (2)
159-160: Verify security considerations for Hailo integration.
Since this introduces new firmware and device access:
- Consider if AppArmor profiles need updates for Hailo device access
- Ensure firmware package includes verification/signing mechanisms
Let's check for security-related configurations:
159-160: LGTM! Verify kernel configuration for Hailo support.
The addition of Hailo packages looks good. The packages are correctly placed and enabled:
BR2_PACKAGE_HAILO8_FIRMWARE=y: Provides the necessary firmwareBR2_PACKAGE_HAILO_PCI=y: Provides the PCIe driver
Let's verify the kernel configuration includes necessary Hailo support:
✅ Verification successful
Kernel configuration for Hailo support looks good to proceed
The verification shows that:
- PCI support is properly configured in the kernel through
device-support-pci.config - The Hailo PCIe driver (v4.19.0) is being built as a kernel module
- The firmware package correctly installs the binary at
/lib/firmware/hailo/hailo8_fw.bin - Since this is a standard PCIe driver that will be built as a module, no additional kernel configurations are required beyond the existing PCI support
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check kernel config fragments for Hailo PCIe support
# Check kernel config fragments for Hailo-related settings
echo "Checking kernel config fragments for Hailo support..."
rg -l "CONFIG_HAILO" "$(BR2_EXTERNAL_HASSOS_PATH)/kernel/v6.6.y/"
# Verify PCI support is properly configured
echo "Verifying PCI configuration..."
rg "CONFIG_PCI" "$(BR2_EXTERNAL_HASSOS_PATH)/kernel/v6.6.y/device-support-pci.config"
Length of output: 705
Script:
#!/bin/bash
# Let's first find the correct paths for kernel configs
echo "Finding kernel config files..."
fd "device-support-pci.config"
echo "Searching for any Hailo-related kernel configs..."
rg -l "CONFIG_HAILO"
echo "Looking for kernel defconfig or fragment files..."
fd "defconfig|\.config" buildroot-external/kernel/
Length of output: 854
Script:
#!/bin/bash
# Now that we have the correct paths, let's check the content of relevant config files
echo "Checking PCI support configuration..."
cat buildroot-external/kernel/v6.6.y/device-support-pci.config
echo -e "\nChecking general device support configuration..."
cat buildroot-external/kernel/v6.6.y/device-support.config
echo -e "\nChecking main kernel configuration..."
cat buildroot-external/kernel/v6.6.y/hassos.config
# Let's also check if there are any Hailo-related patches
echo -e "\nChecking for Hailo-related kernel patches..."
fd -e patch . buildroot-external/kernel/v6.6.y/patches/
Length of output: 9760
Script:
#!/bin/bash
# Let's check if there's a Hailo package definition that might contain kernel config requirements
echo "Checking Hailo package definitions..."
fd "hailo" buildroot-external/package/
echo -e "\nChecking package contents if found..."
find buildroot-external/package/ -type f -name "hailo*" -exec cat {} \;
Length of output: 1988
agners
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCIe card from the RPi AI Kit (and probably other M.2 cards using the Hailo-8 chip) can be used on Yellow - the driver initializes correctly and creates a /dev/hailo0 device on Yellow both with CM4 and CM5.
Summary by CodeRabbit