fix: pass error to status (#21)

honestbank · Apr 1, 2022 · 8f70b5d · 8f70b5d
1 parent 793d157
commit 8f70b5d
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 5 deletions.
diff --git a/mfa/entities/error.go b/mfa/entities/error.go
@@ -0,0 +1,10 @@
+package entities
+
+type MFAError struct {
+	Code    string
+	Message string
+}
+
+func (e MFAError) Error() string {
+	return e.Message
+}
diff --git a/mfa/entities/status.go b/mfa/entities/status.go
@@ -0,0 +1,8 @@
+package entities
+
+const (
+	StatusPassed  string = "PASSED"
+	StatusFailed  string = "FAILED"
+	StatusSkipped string = "SKIPPED"
+	StatusPending string = "PENDING"
+)
diff --git a/mfa/mfa.go b/mfa/mfa.go
@@ -165,7 +165,7 @@ func (m *Service) handleRequest(ctx context.Context, decodedJWT entities.JWTData
 
 	var challenges []string
 	for _, flowChallenge := range requestFlow.GetChallenges(&claims.Challenges, &challenge) {
-		if claims.Challenges[flowChallenge].Status != "passed" {
+		if claims.Challenges[flowChallenge].Status != entities.StatusPassed {
 			challenges = append(challenges, flowChallenge)
 		}
 	}
@@ -202,7 +202,7 @@ func (m *Service) handleSolve(ctx context.Context, decodedJWT entities.JWTData,
 		scopes := make([]string, 0)
 		claims, _ := m.generateClaims(requestFlow, decodedJWT, challenge)
 		claims.Challenges[challenge] = entities.Challenge{
-			Status: "failed",
+			Status: err.(*entities.MFAError).Code,
 		}
 		token, _ := m.JWTService.GenerateToken(claims, scopes)
 		var challenges []string
@@ -217,12 +217,12 @@ func (m *Service) handleSolve(ctx context.Context, decodedJWT entities.JWTData,
 	scopes := make([]string, 0)
 	claims, _ := m.generateClaims(requestFlow, decodedJWT, challenge)
 	claims.Challenges[challenge] = entities.Challenge{
-		Status: "passed",
+		Status: entities.StatusPassed,
 	}
 	token, _ := m.JWTService.GenerateToken(claims, scopes)
 	var challenges []string
 	for _, flowChallenge := range requestFlow.GetChallenges(&claims.Challenges, &challenge) {
-		if claims.Challenges[flowChallenge].Status != "passed" {
+		if claims.Challenges[flowChallenge].Status != entities.StatusPassed {
 			challenges = append(challenges, flowChallenge)
 		}
 	}

diff --git a/mfa/mfa_test.go b/mfa/mfa_test.go
@@ -174,7 +174,10 @@ func TestNewMFAService(t *testing.T) {
 
 		jwtService.EXPECT().GenerateToken(gomock.Any(), gomock.Any()).Return(validJWT, nil)
 
-		mockflow.EXPECT().Solve(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, errors.New("Failed to solve"))
+		mockflow.EXPECT().Solve(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, &entities.MFAError{
+			Code:    "FAILED",
+			Message: "Failed to solve",
+		})
 		mockflow.EXPECT().Validate(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil)
 		mockflow.EXPECT().GetName().Return("test")
 		mockflow.EXPECT().GetChallenges(gomock.Any(), gomock.Any()).Return([]string{"dummy"})