fix: generate token after claims have been processed (#35)

honestbank · May 19, 2023 · cec9046 · cec9046
1 parent 44c21a8
commit cec9046
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/mfa/mfa.go b/mfa/mfa.go
@@ -176,7 +176,6 @@ func (m *Service) handleRequest(ctx context.Context, decodedJWT entities.JWTData
 
 	scopes := make([]string, 0)
 	claims, _ := m.generateClaims(ctx, requestFlow, decodedJWT, &challenge)
-	token, jwtErr := m.JWTService.GenerateToken(claims, scopes)
 
 	if err != nil {
 		if _, ok := claims.Challenges[challenge]; ok {
@@ -197,6 +196,8 @@ func (m *Service) handleRequest(ctx context.Context, decodedJWT entities.JWTData
 		}
 	}
 
+	token, jwtErr := m.JWTService.GenerateToken(claims, scopes)
+
 	if jwtErr != nil {
 		return &entities.MFAResult{
 			Token:      token,