feat: Support no read-replication for Memorystore [DEVOP-4801] #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
ChristianWitts
force-pushed
the
christian/devop-4801-support-no-read-replication
branch
from
f96bb6a
to
175b7a1
Compare
Terraform Format and Style 🖌
|
bibek4699
previously approved these changes
Jul 19, 2024
Sagart-cactus
previously approved these changes
Jul 19, 2024
ChristianWitts
dismissed stale reviews from Sagart-cactus and bibek4699
via
38c6fe9
ChristianWitts
force-pushed
the
christian/devop-4801-support-no-read-replication
branch
from
175b7a1
to
38c6fe9
Compare
Terraform Format and Style 🖌
|
ChristianWitts
force-pushed
the
christian/devop-4801-support-no-read-replication
branch
from
38c6fe9
to
733267d
Compare
Terraform Format and Style 🖌
|
MXfive
previously approved these changes
Jul 24, 2024
| condition = var.replicas >= 1 && var.replicas <= 5 | ||
| error_message = "The valid range for the Standard Tier with read replicas enabled is [1-5] and defaults to 1." | ||
| condition = var.replicas <= 5 | ||
| error_message = "The valid range for the Standard Tier with read replicas enabled is [1-5] and defaults to 0 as the default is zero read-replicas." |
There was a problem hiding this comment.
Since 1.9 you can do cross input variable references in input validations. So can make conditional based on the tier here.
There was a problem hiding this comment.
Oh nice, that's nice to know. I rewrote the validations as preconditions on the resource.
ChristianWitts
force-pushed
the
christian/devop-4801-support-no-read-replication
branch
from
733267d
to
314cb98
Compare
Terraform Format and Style 🖌
|
Refs: #DEVOP-4801 Signed-off-by: Christian Witts <christian@honestbank.com>
ChristianWitts
force-pushed
the
christian/devop-4801-support-no-read-replication
branch
from
314cb98
to
8087bcb
Compare
Terraform Format and Style 🖌
|
MXfive
reviewed
Jul 24, 2024
| @@ -13,11 +13,14 @@ resource "random_id" "instance_suffix" { | |||
| } | |||
|
|
|||
| module "private_network" { | |||
| #checkov:skip=CKV_TF_1:We use the version tag instead of the commit hash | |||
There was a problem hiding this comment.
I thought we skip examples for checkov?
MXfive
approved these changes
Jul 24, 2024
sunilhonest
approved these changes
Jul 24, 2024
bibek4699
approved these changes
Jul 24, 2024
ChristianWitts
deleted the
christian/devop-4801-support-no-read-replication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
Please confirm that you have done the following before requesting reviews:
Description
In order to right-size the current Memorystore instances, we need to not
enforce read-replica contraints as at minimum you require 5GB in order
to enable a read-replica, yet current production instances are utilising
less than 1GB.
Refs: #DEVOP-4801
Signed-off-by: Christian Witts christian@honestbank.com
This change is