fix: semaetic pr fix

honestbank · Jun 14, 2024 · 42f5313 · 42f5313
1 parent 22c182a
commit 42f5313
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/checkov.yaml b/.github/workflows/checkov.yaml
@@ -31,4 +31,4 @@ jobs:
         id: checkov
         uses: bridgecrewio/checkov-action@master
         with:
-          config_file: ".checkov.yaml"
+          config_file: ".checkov.yaml"
diff --git a/.github/workflows/semantic-pr.yaml b/.github/workflows/semantic-pr.yaml
@@ -1,4 +1,4 @@
-name: "Semantic Pull Request"
+name: "semantic-pull-request"
 permissions: read-all
 
 on:
@@ -10,10 +10,10 @@ on:
 
 jobs:
   main:
-    name: Semantic Pull Request
+    name: semantic-pull-request
     runs-on: ubuntu-latest
     steps:
-      - uses: amannn/action-semantic-pull-request@v4
+      - uses: amannn/action-semantic-pull-request@v5
         name: Semantic Pull Request
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/examples/mysql_instance_with_read_replica/main.tf b/examples/mysql_instance_with_read_replica/main.tf
@@ -34,6 +34,10 @@ module "google_service_networking_connection_private_vpc_connection" {
 module "sql_database_instance" {
   source = "../../modules/google_sql_database_instance"
 
+  depends_on = [
+    module.google_service_networking_connection_private_vpc_connection
+  ]
+
   name = "sql-rr-${random_id.instance_suffix.hex}"
   #checkov:skip=CKV_GCP_79:Ensure SQL database is using latest Major version"
   database_version = "MYSQL_8_0"
@@ -62,10 +66,6 @@ module "sql_database_instance" {
   enable_read_replica                                 = true
   read_replica_settings_ip_configuration_ipv4_enabled = true
   read_replica_settings_tier                          = var.settings_tier
-
-  depends_on = [
-    module.google_service_networking_connection_private_vpc_connection
-  ]
 }
 
 module "sql_database" {