Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functionality to prevent deletion of databases across all surfaces, enable Query Insight, and set maintenance window. #34

Merged
merged 2 commits into from
Sep 8, 2023
Merged

feat: Add functionality to prevent deletion of databases across all surfaces, enable Query Insight, and set maintenance window. #34

merged 2 commits into from
Sep 8, 2023

Conversation

bibek4699
Copy link
Contributor

@bibek4699 bibek4699 commented Aug 18, 2023 •
edited
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • The delete protection feature was only enabled for the Terraform API. In this PR, I have enabled it across all surfaces (API, gcloud, Cloud Console, and Terraform) to protect instances from accidental deletion.
    In addition, I have enabled the query insight features and set a maintenance window for the databases. All databases will now be upgraded within the maintenance window timeframe, which is set at 9 AM every day on Monday.

This change is Reviewable

@bibek4699 bibek4699 requested a review from a team as a code owner August 18, 2023 04:33
@bibek4699 bibek4699 requested a review from MXfive August 18, 2023 04:33
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 marked this pull request as draft August 18, 2023 04:40
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 marked this pull request as ready for review August 18, 2023 05:19
@bibek4699 bibek4699 changed the title fix: update the broken functionaity of delete protection settings feat: add functionality to prevent deletion of databases across all surfaces. Aug 18, 2023
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 18, 2023
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 force-pushed the bibek/devop-3271-update-terraform-gcp-sql-module-to-fix-broken-functionality branch from a20d760 to 89aa16b Compare August 18, 2023 12:03
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@pull-request-size pull-request-size bot added size/S and removed size/M labels Aug 18, 2023
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 force-pushed the bibek/devop-3271-update-terraform-gcp-sql-module-to-fix-broken-functionality branch from a4aa30a to 72c7e0e Compare August 21, 2023 02:49
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

MXfive
MXfive requested changes Aug 21, 2023
View reviewed changes
modules/google_sql_database_instance/main.tf Outdated Show resolved Hide resolved
modules/google_sql_database_instance/main.tf Show resolved Hide resolved
modules/google_sql_database_instance/main.tf Show resolved Hide resolved
modules/google_sql_database_instance/main.tf Outdated Show resolved Hide resolved
@bibek4699 bibek4699 requested a review from MXfive August 21, 2023 09:25
@bibek4699 bibek4699 marked this pull request as draft August 22, 2023 02:44
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 7, 2023
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 marked this pull request as ready for review September 7, 2023 10:00
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 force-pushed the bibek/devop-3271-update-terraform-gcp-sql-module-to-fix-broken-functionality branch from c933678 to 7a15bb1 Compare September 7, 2023 10:47
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 changed the title feat: add functionality to prevent deletion of databases across all surfaces. feat: Add functionality to prevent deletion of databases across all surfaces, enable Query Insight, and set maintenance window. Sep 7, 2023
@poom
Copy link
Contributor

poom commented Sep 7, 2023

Why we should 9AM Monday?

MXfive
MXfive approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@MXfive MXfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more than Poom's comments.

@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 force-pushed the bibek/devop-3271-update-terraform-gcp-sql-module-to-fix-broken-functionality branch from 5edfe84 to 900d8d1 Compare September 8, 2023 06:53
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

@bibek4699 bibek4699 merged commit c399ab5 into main Sep 8, 2023
5 checks passed
@bibek4699 bibek4699 deleted the bibek/devop-3271-update-terraform-gcp-sql-module-to-fix-broken-functionality branch September 8, 2023 08:11
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilhonest sunilhonest sunilhonest approved these changes

@MXfive MXfive MXfive approved these changes

@poom poom poom approved these changes

@cyberhck cyberhck Awaiting requested review from cyberhck

@maetolay maetolay Awaiting requested review from maetolay

@jeremyrajan jeremyrajan Awaiting requested review from jeremyrajan

Assignees
No one assigned
Labels
released size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bibek4699 @honestbank-bot @poom @MXfive @sunilhonest