New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | [DEVOP-4525] #44

Merged

bibek4699 merged 1 commit into main from bibek/hot-fix

Jun 18, 2024

Contributor

bibek4699 commented Jun 17, 2024 •

edited

Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

I have confirmed that the PR type is appropriate for the change I am making according to the Honest Pull Request and Commit Message Naming Conventions.
I have typed an adequate description that explains why I am making this change.
I have installed and run standard pre-commit hooks that lints and validates my code.

Description

Terrtest is continuously failing with below error, full logs here

│ Error: Error, failed to delete instance sql-rr-7e3cc80c-read-replica: Error waiting for Delete Instance: couldn't find resource (21 retries)
│ 
│ 
╵***
=== CONT  TestTerraformCreateGCPSQL/create_mysql_with_read_replica
    destroy.go:11: 
        	Error Trace:	/home/runner/work/terraform-gcp-sql/terraform-gcp-sql/test/destroy.go:11
        	            				/home/runner/work/terraform-gcp-sql/terraform-gcp-sql/test/gcp_sql_test.go:71
        	Error:      	Received unexpected error:
        	            	FatalError***Underlying: error while running command: exit status 1; ╷
        	            	│ Error: Error, failed to delete instance sql-rr-7e3cc80c-read-replica: Error waiting for Delete Instance: couldn't find resource (21 retries)
        	            	│ 
        	            	│ 
        	            	╵***
        	Test:       	TestTerraformCreateGCPSQL/create_mysql_with_read_replica

It appears there is a bug in the terraform-google-provider. After reviewing the comments, I discovered that auto retry logic could resolve the issue. Since this functionality is not available in Terratest, I implemented a workaround logic.

Additionally, I updated GitHub Actions and upgraded the Go version to the latest. The Go version update was necessary due to deprecated dependencies.

This change is

bibek4699 requested a review from a team as a code owner

June 17, 2024 16:34

bibek4699 requested a review from jai

June 17, 2024 16:34

pull-request-size bot added the size/L label

bibek4699 marked this pull request as draft

June 17, 2024 16:34

Contributor

honestbank-bot commented Jun 17, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 removed the request for review from jai

June 17, 2024 16:34

bibek4699 force-pushed the bibek/hot-fix branch from 5070c96 to 91c0df6 Compare

June 17, 2024 16:40

Contributor

honestbank-bot commented Jun 17, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 91c0df6 to 0b2ba30 Compare

June 17, 2024 16:42

Contributor

honestbank-bot commented Jun 17, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 0b2ba30 to 9b0ccaf Compare

June 17, 2024 16:44

Contributor

honestbank-bot commented Jun 17, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 9b0ccaf to 8ce78c9 Compare

June 17, 2024 16:48

Contributor

honestbank-bot commented Jun 17, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 8ce78c9 to 034d17b Compare

June 18, 2024 02:52

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 034d17b to 7107116 Compare

June 18, 2024 03:39

pull-request-size bot added size/M and removed size/L labels

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 7107116 to 91f7b79 Compare

June 18, 2024 04:07

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 91f7b79 to 826c506 Compare

June 18, 2024 04:11

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 826c506 to d8e6d11 Compare

June 18, 2024 04:21

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from d8e6d11 to 2159825 Compare

June 18, 2024 04:31

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 2159825 to ab289da Compare

June 18, 2024 06:21

pull-request-size bot removed the size/M label

pull-request-size bot added the size/XL label

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from ab289da to 2a41575 Compare

June 18, 2024 06:35

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 2a41575 to 55628cb Compare

June 18, 2024 06:58

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 force-pushed the bibek/hot-fix branch from 55628cb to 8a36314 Compare

June 18, 2024 07:04

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform


          fix: enable cache

4555c0e

bibek4699 force-pushed the bibek/hot-fix branch from 8a36314 to 4555c0e Compare

June 18, 2024 07:13

Contributor

honestbank-bot commented Jun 18, 2024

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @bibek4699, Action: pull_request, Working Directory: ``, Workflow: terraform

bibek4699 changed the title ~~fix: terratest~~ fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | DEVOP-4525

bibek4699 marked this pull request as ready for review

June 18, 2024 07:29

bibek4699 changed the title ~~fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | DEVOP-4525~~ fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | [DEVOP-4525]

ChristianWitts approved these changes

View reviewed changes

Sagart-cactus approved these changes

View reviewed changes

bibek4699 merged commit 2e73d11 into main

11 of 12 checks passed

bibek4699 deleted the bibek/hot-fix branch

June 18, 2024 08:31

github-actions bot commented Jun 18, 2024

🎉 This PR is included in version 1.13.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size/XL