Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | [DEVOP-4525] #44

Merged
merged 1 commit into from
Jun 18, 2024

fix: enable cache

4555c0e
Select commit
Loading
Failed to load commit list.
Merged

fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | [DEVOP-4525] #44

fix: enable cache
4555c0e
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Jun 18, 2024 in 1s

1/3 Fail(s): SIZE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must include '\b(acq|da|data|dec|devop|ds|mlops|nerds|qa|sec|spe|ss|it)-\d+\b|chore: synced file(s)'
    Input : fix: Resolve Terratest Failure During Instance Deletion (21 Retries) | [DEVOP-4525]
    Settings : {"must_include":{"regex":"\\b(acq|da|data|dec|devop|ds|mlops|nerds|qa|sec|spe|ss|it)-\\d+\\b|chore: synced file\\(s\\)","message":"The PR title should have a Linear ticket ID. Please check Honest Engineering PR conventions <a href=\"https://www.notion.so/honestbank/Pull-Request-and-Commit-Message-Naming-Conventions-bd97f2cbb34c4c73b1ff3a3e384b850c?pvs=4\">here</a>.\n"}}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: enable cache
    Settings : {"do":"commit","message":{"regex":"^(feat|docs|chore|fix|refactor|test|style|perf|ci|build)(\\(\\w+\\))?:(.+|\\n)+$","message":"Your commit(s) don't adhere to Honest Engineering PR conventions <a href=\"https://www.notion.so/honestbank/Pull-Request-and-Commit-Message-Naming-Conventions-bd97f2cbb34c4c73b1ff3a3e384b850c?pvs=4\">here</a>."}}

❌ Validator: SIZE

  • Change is very large. Should be under 500 lines of additions.
    Input : 791 total, 715 additions, 76 deletions
    Files: .github/workflows/terratest.yml,test/gcp_sql_test.go,test/go.mod,test/go.sum
    Settings : {"do":"size","ignore":["**/*.json","**/*.lock","**/*.xml","**/*_test.go","**/generated/**","**/go.mod","**/go.sum","**/mocks/**","**/pyproject.toml","**/tests/**"],"lines":{"additions":{"count":500,"message":"Change is very large. Should be under 500 lines of additions."},"ignore_comments":true}}