Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide DB instance server CA pem as terraform output [DEVOP-5018] #47

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat: Provide DB instance server CA pem as terraform output [DEVOP-5018] #47

merged 1 commit into from
Sep 3, 2024

Conversation

sunilhonest
Copy link
Contributor

@sunilhonest sunilhonest commented Sep 3, 2024 •
edited by jai
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

This PR adds code to provide DB instance server CAs as terraform outputs

This change is Reviewable

@sunilhonest sunilhonest requested a review from a team as a code owner September 3, 2024 04:07
@sunilhonest sunilhonest marked this pull request as draft September 3, 2024 04:07
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @sunilhonest, Action: pull_request, Working Directory: ``, Workflow: terraform

@sunilhonest sunilhonest changed the title feat: Provide DB instance server CA pem as terraform output feat: Provide DB instance server CA pem as terraform output [DEVOP-5018] Sep 3, 2024
@sunilhonest sunilhonest force-pushed the sunil/devop-5018-provide-db-instance-server-ca-pem-as-terraform-output branch from d0207c8 to 2312e8c Compare September 3, 2024 04:33
@honestbank-bot
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Pusher: @sunilhonest, Action: pull_request, Working Directory: ``, Workflow: terraform

@sunilhonest sunilhonest marked this pull request as ready for review September 3, 2024 05:18
@sunilhonest sunilhonest merged commit de961b7 into main Sep 3, 2024
6 checks passed
@sunilhonest sunilhonest deleted the sunil/devop-5018-provide-db-instance-server-ca-pem-as-terraform-output branch September 3, 2024 06:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sagart-cactus Sagart-cactus Sagart-cactus approved these changes

@ChristianWitts ChristianWitts ChristianWitts approved these changes

@MXfive MXfive Awaiting requested review from MXfive MXfive is a code owner automatically assigned from honestbank/devops-engineers

@bibek4699 bibek4699 Awaiting requested review from bibek4699

Assignees
No one assigned
Labels
released size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunilhonest @honestbank-bot @ChristianWitts @Sagart-cactus