Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event stats for sidekiq and sq #638

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

roelbondoc
Copy link
Member

Similar to Karafka's stats event, this adds the collected cluster based stats as a wide event for Sidekiq and SolidQueue. The previous aggregated metrics can be toggled on, while the new events can be toggled off.

# Turn off all events for Sidekiq and SolidQueue
sidekiq:
  insights:
    events: false
solid_queue:
  insights:
    events: false

# Turn on all aggregated metrics for Sidekiq and SolidQueue
sidekiq:
  insights:
    metrics: true
solid_queue:
  insights:
    metrics: true

In addition, the polling interval has been decreased to 5 seconds to allow for up to date readings.

Before submitting a pull request, please make sure the following is done:

  1. If you've fixed a bug or added code that should be tested, add tests!
  2. Run rake spec in the repository root.
  3. Use a pull request title that conforms to conventional commits.

Similar to Karafka's stats event, this adds the collected cluster based
stats as a wide event for Sidekiq and SolidQueue. The previous
aggregated metrics can be toggled on, while the new events can be
toggled off.

```
sidekiq:
  insights:
    events: false
solid_queue:
  insights:
    events: false

sidekiq:
  insights:
    metrics: true
solid_queue:
  insights:
    metrics: true
```

In addition, the polling interval has been decreased to 5 seconds to
allow for up to date readings.
@roelbondoc roelbondoc requested a review from a team November 12, 2024 20:54
@roelbondoc roelbondoc merged commit 0d15bf5 into master Nov 14, 2024
59 checks passed
@roelbondoc roelbondoc deleted the sidekiq-solid-queue-event-stats branch November 14, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants