Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull --writekey From Environment Variable #75

Closed
elliottpope opened this issue Oct 16, 2023 · 1 comment
Closed

Pull --writekey From Environment Variable #75

elliottpope opened this issue Oct 16, 2023 · 1 comment

Comments

@elliottpope
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am trying to use Honeymarker for some Kubernetes automation. It would be easier to source the Honeycomb API key from a Secret injected into the container environment. Since the provided container is built from scratch there is no available Shell to do environment variable expansion

Describe the solution you'd like

The underlying command line option parser allows for specifying environment variable defaults (jessevdk/go-flags#309). We could add env:"HONEYCOMB_API_KEY" to the WriteKey struct tag here to pull from the environment I believe

Describe alternatives you've considered

I don't want to put the API key in plain text in the K8s manifest since this won't allow me to swap out the key value in different environments (i.e. dev, test, production) while keeping the same manifest definition

Additional context

@jharley
Copy link
Contributor

jharley commented Oct 23, 2023

Closed by #76

@jharley jharley closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants