Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #96 short version of sensor id added in backend #100

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

Tushar-kalsi
Copy link
Contributor

Removed split function from front end and added it to backend . Before sending data to front end sensorID is split .

Fixed honeynet#96

Some changes in handler.go file in publishHandler function intersepted msg []byte object decode it , made changes as per requirnments .
…ckend

Removed .split ('-')[0] from front end code and already added this logic in backend
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
I have made changes as per discussion please review .
backend/handlers.go Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Very close, just some minor formatting issues 💪

backend/handlers.go Outdated Show resolved Hide resolved
backend/handlers.go Outdated Show resolved Hide resolved
Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@glaslos glaslos merged commit f7f4b08 into honeynet:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants