fs2dt: Fix for parsing/reading entries > 4k #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device-tree only does 4k reads at a time, so for entries greater than that, the fs2dt code would fail, assuming a single read would get the whole item. Added helper function to continue reading as long as there was data and no errors. This was evident from: /proc/device-tree/soc@ffe000000/fman@400000/fman-firmware/fsl,firmware On my P4080 system, which is 29668 bytes. Signed-off-by: Ben Collins <ben@cyphre.com>
ryncsn
added a commit
to ryncsn/kexec-tools
that referenced
this pull request
Mar 8, 2020
|
Instead of defining its own auxiliary routine, I think this could now use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device-tree only does 4k reads at a time, so for entries greater
than that, the fs2dt code would fail, assuming a single read would get
the whole item.
Added helper function to continue reading as long as there was data and
no errors.
This was evident from:
/proc/device-tree/soc@ffe000000/fman@400000/fman-firmware/fsl,firmware
On my P4080 system, which is 29668 bytes.
Signed-off-by: Ben Collins ben@cyphre.com