Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating pmtiles with different file extensions, update XLSForm ordering #278

Merged
merged 14 commits into from
Jul 30, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Jul 30, 2024

Issues

Fixes

  • Extract the file extension from the tile download, then write the PMTile using specified format.
    • OAM for example downloads by default as .jpg, but it is also possible to add the extension .png to the URL to download PNG format too. It is obviously a much larger file however, and not worth the lossless compression for aerial imagery.
  • The digitization verification questions were moved to the end of the XLSForm survey.
    • It's hidden, but could be accidentally deleted by the user if they bulk delete below a certain line. Let's see how it goes.
    • The choices sheet can used a sortby column for sorting, but I don't think such a thing is possible in the survey sheet.
    • If we can manually specify the question sorting, then putting all mandatory fields at the top and hiding would be ideal.

@spwoodcock
Copy link
Member Author

Merging this early to get it in FMTM for the webinar tomorrow.

@spwoodcock
Copy link
Member Author

This was a small refactor, but turned into a bit of a rabbit hole.

Needed to fix the pmtile generation correctly using xy param.
I did a big refactor to improve code readability (imo), which helped me during the debugging process.

@spwoodcock spwoodcock merged commit ccf87dc into main Jul 30, 2024
3 of 5 checks passed
@spwoodcock spwoodcock deleted the fix/pmtile-formats branch July 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: Should have
Projects
Development

Successfully merging this pull request may close these issues.

1 participant