New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex pattern to find spaces in placeholders of tms url #283

Merged

spwoodcock merged 1 commit into main from fix/regex-pattern

Aug 8, 2024

Contributor

Sujanadh commented Aug 7, 2024

Updates:

refactored the regex pattern to search any spaces within placeholders in the tms url.
only checks for them if they are present in url.
pattern is r".*/\{[zxy]\}/\{[zxy]\}/\{[zxy]\}(?:/|/?)" which ensures placeholders without spaces for all possible combination of them, such as {z}{x}{y}, {x}{y}{z} etc.


          fix: regex pattern to find spaces in placeholders of tms url

f28fe2d

Sujanadh requested a review from spwoodcock

August 7, 2024 04:37

Sujanadh self-assigned this

Sujanadh temporarily deployed to test

August 7, 2024 04:37

— with

GitHub Actions Inactive

github-actions bot added the bug label

Sujanadh temporarily deployed to test

August 7, 2024 04:37

— with

GitHub Actions Inactive

spwoodcock approved these changes

View reviewed changes

spwoodcock merged commit 5c943e2 into main

4 of 5 checks passed

spwoodcock deleted the fix/regex-pattern branch

August 8, 2024 12:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug