Update the adapter js to match the updated changes in strada-web
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (34 commits) Bump the gradle plugin to 8.1.0 Update .idea git-ignored files Open up the component's didReceive(), didStart(), and didStop() for use with app component testing Update Android Gradle plugin to 8.0.2 Include the stack trace in logged errors Improve logging and expose warnings to apps that don't have debug logging enabled Don't access the bridge directly from the component, so testing from apps is possible through the delegate directly Move the debugLoggingEnabled flag to the Strada.config namespace Move userAgent substring generation from Bridge to Strada namespace Add tests for message data encoding/decoding Provide an available KotlinXJsonConverter, since the kotlinx.serialization is multiplatform and requires inline reified functions, which aren't compatible with a generic interface or abstract class Rename StradaJsonEncoder -> StradaJsonConverter Cleanup Initial work to encode/decode data by providing Strada a custom app encoder Rename messageReceivedFor(event) -> receivedMessageFor(event) Make the component's onStart() and onStop() have protected access, so it's only available to component subclasses Update BridgeComponent tests with the boolean flag when replying Allow replying to an event without modifying its jsonData. Return a boolean flag from replies to indicate whether the reply was successful. Consolidate test data to a new TestData object Store the last received message for each event type so it can be easily retrieved and add a new replyTo() convenience way to reply to messages ... # Conflicts: # strada/src/main/assets/js/strada.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the adapter js for compatibility with the changes in: hotwired/strada-web#2
This corresponds to the same iOS changes made in: hotwired/strada-ios#2