Delegate Turbo.session properties to Turbo.config
#1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to comment on [238ec26][] [hotwired#1216][] unintentionally removed support for the `Turbo.session.drive` boolean property and the `Turbo.session.formMode` string property. This commit re-introduces that support by delegating reads and writes to those properties to their corresponding `Turbo.config` versions. [hotwired#1216]: hotwired#1216 [238ec26]: hotwired@238ec26#commitcomment-145954235
seanpdoyle
referenced
this pull request
Aug 28, 2024
The initial implementation aims to replace the ad hoc configurations spread across `window.Turbo` and `Turbo.session`. Those objects shouldn't be considered part of the public interface, especially for extension. This commit exports a single object from `src/core/config` to serve as a centralized, user-facing repository for configuration values. The main `src/core/config` object is composed of two constituent parts: * `src/core/config/drive` * `src/core/config/forms` In the future, the directory structure can be expanded upon to suit the needs of the project. Any user-facing configuration outside of `Turbo.config` is deprecated.
|
@jorgemanrubia and @brunoprietog, could one of you review this change? @botandrose caught it and reported it on the original commit. |
Browser tests periodically fail due to a timing issue:
```
1) [firefox] › functional/frame_tests.js:190:5 › failing to follow a link to a page without a matching frame shows an error and throws an exception
AssertionError: expected 'Missing frame Missing page Unvisitabl…' to match /Content missing/
196 | await page.click("#missing-page-link")
197 |
> 198 | assert.match(await page.innerText("#missing"), /Content missing/)
| ^
199 |
200 | assert.exists(error)
201 | assert.include(error.message, `The response (404) did not contain the expected <turbo-frame id="missing">`)
```
This commit replaces the `assert`-based assertion with an `expect`-based
Playwright assertion that will utilize retries and timing
synchronization.
[CI failure]: https://github.com/hotwired/turbo/actions/runs/10603228414/job/29387060926?pr=1306#step:11:18
|
Right! Could you add deprecation warnings please? |
|
@brunoprietog I'm happy to do that. It's worth mentioning that the original PR only deprecated the methods like I think deprecating the |
|
Ah, yes, makes sense. Thanks @seanpdoyle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to comment on 238ec2688b2f4907e05ad1eaeb011e93bae75995
hotwired/turbo#1216 unintentionally removed support for the
Turbo.session.driveboolean property and theTurbo.session.formModestring property.This commit re-introduces that support by delegating reads and writes to those properties to their corresponding
Turbo.configversions.