Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

several fixes related to -W testing #1892

Merged
merged 8 commits into from
Apr 22, 2024
Merged

several fixes related to -W testing #1892

merged 8 commits into from
Apr 22, 2024

Conversation

reidpr
Copy link
Collaborator

@reidpr reidpr commented Apr 18, 2024

Closes #1893.
Closes #1894.
Closes #1895.
Closes #1897.

@reidpr reidpr added this to the 0.38 milestone Apr 18, 2024
@reidpr reidpr self-assigned this Apr 18, 2024
@reidpr reidpr changed the title fix -W detection several fixes related to -W testing Apr 19, 2024
@reidpr reidpr removed their assignment Apr 19, 2024
@reidpr reidpr removed this from the 0.38 milestone Apr 19, 2024
Copy link
Collaborator

@lucaudill lucaudill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion in-line.

bin/ch-run.c Show resolved Hide resolved
@reidpr reidpr requested a review from lucaudill April 22, 2024 21:31
Copy link
Collaborator

@lucaudill lucaudill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidpr reidpr merged commit 649c710 into master Apr 22, 2024
@reidpr reidpr deleted the test-write-fake branch April 22, 2024 21:35
kchilleri pushed a commit that referenced this pull request May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants