Skip to content

Commit

Permalink
Merge pull request #14 from hpc4cmb/docker_ld
Browse files Browse the repository at this point in the history
Remove sourcing of cmbenv in docker entrypoint.
  • Loading branch information
tskisner committed Apr 22, 2022
2 parents 9352d13 + 88b8242 commit 7feb9e8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkgs/mpich.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cleanup=""

version=3.4
pfile=mpich-${version}.tar.gz
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" http://www.mpich.org/static/downloads/${version}/${pfile} ${pfile})
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" https://www.mpich.org/static/downloads/${version}/${pfile} ${pfile})

if [ "x${src}" = "x" ]; then
echo "Failed to fetch ${pkg}" >&2
Expand Down
6 changes: 3 additions & 3 deletions pkgs/zlib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ pkg="zlib"
pkgopts=$@
cleanup=""

version=1.2.11
version=1.2.12
pfile=zlib-${version}.tar.gz
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" http://zlib.net/${pfile} ${pfile})
src=$(eval "@TOP_DIR@/tools/fetch_check.sh" https://zlib.net/${pfile} ${pfile})

if [ "x${src}" = "x" ]; then
echo "Failed to fetch ${pkg}" >&2
Expand All @@ -26,7 +26,7 @@ rm -rf zlib-${version}
tar xzf ${src} \
&& cd zlib-${version} \
&& cleanup="${cleanup} $(pwd)" \
&& CC="@BUILD_CC@" ./configure \
&& CC="@BUILD_CC@" CFLAGS="-O3 -fPIC" ./configure \
--shared --prefix="@AUX_PREFIX@" > ${log} 2>&1 \
&& make -j @MAKEJ@ >> ${log} 2>&1 \
&& make install >> ${log} 2>&1
Expand Down
6 changes: 5 additions & 1 deletion tools/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ _is_sourced() {
# Loads various settings that are used elsewhere in the script
# This should be called before any other functions
docker_setup_env() {
source cmbenv
# Our docker builds install to /usr/local, so this is
# not needed. In fact, it can cause problems since the
# setup script will manipulate LD_LIBRARY_PATH.
#source cmbenv
echo "" > /dev/null
}

_main() {
Expand Down

0 comments on commit 7feb9e8

Please sign in to comment.