Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option in the detector pointing operator to deflect the pointing … #776

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Add option in the detector pointing operator to deflect the pointing … #776

merged 3 commits into from
Aug 16, 2024

Conversation

keskitalo
Copy link
Member

…based on the HWP angle

@keskitalo keskitalo requested a review from tskisner August 6, 2024 19:22
tskisner
tskisner requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this feature! I think if we add a phase to the deflection then it should cover all known cases so far.

src/toast/ops/pointing_detector/pointing_detector.py Show resolved Hide resolved
src/toast/ops/pointing_detector/pointing_detector.py Outdated Show resolved Hide resolved
@tskisner
Copy link
Member

Thanks for the update, merge when ready

@keskitalo keskitalo merged commit 2ad64fd into toast3 Aug 16, 2024
6 checks passed
@keskitalo keskitalo deleted the hwp_deflection branch August 16, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keskitalo @tskisner