feat: Switch to esbuild and ESM first packaging (comms) #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
force-pushed
the
JAS_TO_VITEST
branch
21 times, most recently
from
57440a7
to
4866138
Compare
Switch to vitest from Jasmine Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
JAS_TO_VITEST
branch
from
4866138
to
3bc7e54
Compare
jeclrsg
reviewed
Oct 1, 2024
There was a problem hiding this comment.
@GordonSmith only thing that jumped out at me were all those references to "xpackages" in the package.json
| "demos/react/*", | ||
| "tests/*" | ||
| "xutils/*", | ||
| "xpackages/api", |
There was a problem hiding this comment.
lots of references to "xpackages" in here. is that because you're mostly only concerned with comms?
There was a problem hiding this comment.
Its just my way of excluding the ones that have not been migrated yet...
jeclrsg
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to vitest from Jasmine
Checklist:
Testing: