Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace: construct a CCT #29

Merged
merged 43 commits into from
Nov 14, 2023
Merged

Trace: construct a CCT #29

merged 43 commits into from
Nov 14, 2023

Conversation

adityaranjan
Copy link
Collaborator

@adityaranjan adityaranjan commented Sep 12, 2022

  1. implementation of cct
  2. verified with external tools like vampir for otf2 traces

@adityaranjan adityaranjan changed the title feat: otf2 cct Feature: CCT Sep 23, 2022
adityaranjan and others added 2 commits September 26, 2022 16:19
* tracedata schema

* renaming column

* tracedata schema

* renaming column

* move p2p to trace.py

* remove .pyc files

* cleaned up communication matrix function and added documentation

* docs: specify sender/receiver dimensions in top level function comment

Co-authored-by: Abhinav Bhatele <bhatele@cs.umd.edu>
@jordanmarry jordanmarry self-requested a review October 14, 2022 16:34
@jordanmarry jordanmarry self-requested a review October 14, 2022 17:06
@bhatele
Copy link
Member

bhatele commented Oct 14, 2022

We need to test this with nsight data

@adityaranjan adityaranjan changed the title Feature: CCT Trace: CCT Oct 16, 2022
@hpcgroup hpcgroup deleted a comment from jordanmarry Nov 12, 2022
hsirkar added a commit that referenced this pull request Nov 13, 2022
@bhatele
Copy link
Member

bhatele commented Sep 1, 2023

Lets make the CCT construction optional (dependent on user input)

@bhatele bhatele added this to the Pipit release v0.0.2 milestone Oct 13, 2023
@adityaranjan adityaranjan removed the request for review from jordanmarry October 22, 2023 19:50
pipit/trace.py Outdated
Currently, the DataFrame index of the entry row is being stored
in the node's calling context ids. This doesn't really have much of a
purpose right now. What should we be storing as calling context ids
for OTF2? Perhaps there should also be a way to map entry rows to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolved by match_rows() function from #44 right?

@bhatele bhatele changed the title Trace: CCT Trace: construct a CCT Nov 14, 2023
@bhatele bhatele merged commit ae4080e into develop Nov 14, 2023
8 checks passed
@bhatele bhatele deleted the feat/otf2-cct branch November 14, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants