feature: add pattern detection #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaranjan
reviewed
Nov 3, 2023
adityaranjan
reviewed
Nov 3, 2023
adityaranjan
reviewed
Nov 3, 2023
adityaranjan
reviewed
Nov 3, 2023
ocnkr
force-pushed
the
pattern-detection
branch
from
9b5a62c
to
11cba01
Compare
pipit/trace.py
Outdated
| # the given event. we will only investigate | ||
| # this portion of the data. | ||
| first_loop_enter = self.events[ | ||
| (self.events["Name"] == start_event) |
There was a problem hiding this comment.
this and line 716 seem like repeated filtering/computation since we already do it once on line 701. maybe we could store this "iterations" filter in a variable?
| & (self.events["Process"] == process) | ||
| ].index[-1] | ||
|
|
||
| df = self.events.iloc[first_loop_enter + 1 : last_loop_leave] |
There was a problem hiding this comment.
any reason why we don't include first_loop_enter and last_loop_leave themselves?
There was a problem hiding this comment.
I don't remember but I will think about it and add comments
bhatele
force-pushed
the
pattern-detection
branch
from
597a8c5
to
b5f61bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.