-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add pattern detection #93
Conversation
9b5a62c
to
11cba01
Compare
pipit/trace.py
Outdated
# the given event. we will only investigate | ||
# this portion of the data. | ||
first_loop_enter = self.events[ | ||
(self.events["Name"] == start_event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and line 716 seem like repeated filtering/computation since we already do it once on line 701. maybe we could store this "iterations" filter in a variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
& (self.events["Process"] == process) | ||
].index[-1] | ||
|
||
df = self.events.iloc[first_loop_enter + 1 : last_loop_leave] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we don't include first_loop_enter and last_loop_leave themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember but I will think about it and add comments
597a8c5
to
b5f61bc
Compare
No description provided.