Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace SimpleOption by a ConfigArgParser wrapper class (HPC-10990) #94

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

itkovian
Copy link
Member

@itkovian itkovian commented Jan 8, 2024

No description provided.

@itkovian itkovian marked this pull request as draft January 8, 2024 20:42
class ExtendedSimpleOption(SimpleOption):
class ConfigOption:
"""
Allow using configargparse.ArgParser instead of GeneralOption but with the same
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm quite sure that same doesn't mean what you think it means ;)
anyway, best to start with a separate named class, and start to swap it in controlled way. then we can see what features are not used.

but tbh, i fail to see the need at all. if you want to make a general option with this configargparse as backend, then go for that and do this in vsc-base.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get rid of GeneralOption altogether.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why you want this, but starting in this repo is not the correct place imho.
it's better to have a look what "features" of generaloption we don't want anymore, and then look for code where they are used; and then estimate the amount of work to replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants