Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate software-specific pages in overview of available software #559

Merged
merged 27 commits into from
Sep 1, 2023

Conversation

milachae
Copy link
Contributor

PR with the detailed overviews of all the software.
First merge #554 before this.

#553

@milachae milachae changed the title Module list detail Module overview with detail pages Aug 28, 2023
@milachae milachae force-pushed the module_list_detail branch 2 times, most recently from 0b023f9 to 228caf6 Compare August 29, 2023 13:58
# Conflicts:
#	config/templates/hpc.template
#	mkdocs/docs/HPC/data/json_data.json
#	mkdocs/docs/HPC/only/gent/module_overview/index.md
#	scripts/module_overview/tests/data/test_json_simple_sol.json
#	scripts/module_overview/tests/test_json.py
@milachae milachae mentioned this pull request Aug 30, 2023
8 tasks
@milachae milachae marked this pull request as ready for review August 31, 2023 13:12
@milachae
Copy link
Contributor Author

@boegel
ready for review

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • rename module_overview.py to available_software.py
  • collapse module_detail.py in available_software.py
  • add a README.txt in data/ and detail/ subdirs

mkdocs/extra/gent.yml Outdated Show resolved Hide resolved
scripts/available_software/README.md Outdated Show resolved Hide resolved
scripts/available_software/README.md Outdated Show resolved Hide resolved
scripts/available_software/README.md Outdated Show resolved Hide resolved
scripts/available_software/README.md Outdated Show resolved Hide resolved
scripts/available_software/available_software.py Outdated Show resolved Hide resolved
scripts/available_software/available_software.py Outdated Show resolved Hide resolved
@milachae milachae requested a review from boegel September 1, 2023 06:53
@milachae
Copy link
Contributor Author

milachae commented Sep 1, 2023

@boegel
I applied all suggestions!

At this moment, this is the current look of the detail pages:
image

@boegel boegel changed the title Module overview with detail pages Generate software-specific pages in overview of available software Sep 1, 2023
@boegel boegel merged commit b5547f1 into hpcugent:main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants