Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #160 through explicit addition of KEY_TAB #163

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jgrenda
Copy link
Collaborator

@jgrenda jgrenda commented Sep 6, 2023

Added KEY_TAB to register for accepting the selected method from the autocompletion drow-down window in the node_to_node_configurator dialog.
It is necessary to either undo or prevent the additional focus switch that tab triggered.
As we can't use the find_prev_valid_focus method to do this in the _gui_input method (because we are at the first index) we instead check the key type again in the selected method and prevent additional focus movement if the key type was tab.

@tom95
Copy link
Contributor

tom95 commented Sep 6, 2023

Perfect, thank you!

@tom95 tom95 merged commit a5bef22 into master Sep 6, 2023
1 of 2 checks passed
@jgrenda jgrenda deleted the bugfix/#160/tab-autocompletion-on-method-select branch September 9, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants