Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dashboard controller #474

Open
chrisma opened this issue Mar 14, 2019 · 0 comments
Open

Refactor dashboard controller #474

chrisma opened this issue Mar 14, 2019 · 0 comments
Labels
prio: medium This is a medium priority issue. refactoring

Comments

@chrisma
Copy link
Contributor

chrisma commented Mar 14, 2019

the methods initialize_vm_categories and filter_vm_categories seem duplicated in app/controllers/vms_controller.rb and app/controllers/dashboard_controller.rb.
Can the code be reused?

Can the dashboard controller be deleted (it has only the index REST route) and the functionality be added to the application controller?
@chrisma chrisma mentioned this issue Mar 14, 2019
Merged
@chrisma chrisma changed the title Refactor app/controllers/dashboard_controller.rb Refactor dashboard controller Mar 14, 2019
@chrisma chrisma added the prio: medium This is a medium priority issue. label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: medium This is a medium priority issue. refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisma