MPRIS: can_go_previous should always be true #1346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently, the MPRIS previous does nothing when the song is the first in the queue, when it should restart the song (as is the case if one uses the
previous
keyboard shortcut in the TUI). This can fixed by making the MPRIS functioncan_go_previous
identically true, rather than checking if there's a previous song in the queue.Issue ticket number and link
One might consider this is somewhat related to #1110?
Checklist before requesting a review
not performance improvements, etc.)