Tab Completion not working as expected

[bytebeast]

Using the following, from LazyVim example:

  -- Use <tab> for completion and snippets (supertab)
  -- first: disable default <tab> and <s-tab> behavior in LuaSnip
  {
    "L3MON4D3/LuaSnip",
    keys = function()
      return {}
    end,
  },
  -- then: setup supertab in cmp
  {
    "hrsh7th/nvim-cmp",
    dependencies = {
      "hrsh7th/cmp-emoji",
    },
    ---@param opts cmp.ConfigSchema
    opts = function(_, opts)
      local has_words_before = function()
        unpack = unpack or table.unpack
        local line, col = unpack(vim.api.nvim_win_get_cursor(0))
        return col ~= 0 and vim.api.nvim_buf_get_lines(0, line - 1, line, true)[1]:sub(col, col):match("%s") == nil
      end

      local luasnip = require("luasnip")
      local cmp = require("cmp")

      opts.mapping = vim.tbl_extend("force", opts.mapping, {
        ["<Tab>"] = cmp.mapping(function(fallback)
          if cmp.visible() then
            cmp.select_next_item()
            -- You could replace the expand_or_jumpable() calls with expand_or_locally_jumpable()
            -- they way you will only jump inside the snippet region
          elseif luasnip.expand_or_jumpable() then
            luasnip.expand_or_jump()
          elseif has_words_before() then
            cmp.complete()
          else
            fallback()
          end
        end, { "i", "s" }),
        ["<S-Tab>"] = cmp.mapping(function(fallback)
          if cmp.visible() then
            cmp.select_prev_item()
          elseif luasnip.jumpable(-1) then
            luasnip.jump(-1)
          else
            fallback()
          end
        end, { "i", "s" }),
      })
    end,
  },

I guess i'm expecting for completion options to only appear after pressing <TAB> , but this does not seem to be the case.

If I create the following file test.py;

#!/usr/bin/env python

testvar = 2

After entering the number 2 and press <RETURN> , i get a big blob of bsd license.
It looks like when I press 2 the completion window automatically pops up with the first bsd license completion option selected, and when I press <RETURN> it selects it.

How can i make it so completion pop up window only appear on <TAB> ?

( there is a very high possibility i'm doing something wrong )

[twiddli]

In the same vein, I'm trying to have both TAB and CR snippets from the wiki working together. TAB works but not CR when I specifically select something. Not sure why:

{
                'hrsh7th/nvim-cmp',
                config = function()
                    local cmp = require("cmp")
                    cmp.setup({
                        mapping = {
                            -- If nothing is selected (including preselections) add a newline as usual.
                            -- If something has explicitly been selected by the user, select it.
                            ["<Enter>"] = cmp.mapping({
                                i = function(fallback)
                                    if cmp.visible() and cmp.get_active_entry() then
                                        cmp.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = false })
                                    else
                                        fallback()
                                    end
                                end,
                                s = cmp.mapping.confirm({ select = true }),
                                c = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = true }),
                            }),
                            ["<Tab>"] = cmp.mapping(function(fallback)
                                -- This little snippet will confirm with tab, and if no entry is selected, will confirm the first item
                                if cmp.visible() then
                                    local entry = cmp.get_selected_entry()
                                    if not entry then
                                        cmp.select_next_item({ behavior = cmp.SelectBehavior.Select })
                                    else
                                        cmp.confirm()
                                    end
                                else
                                    fallback()
                                end
                            end, { "i", "s", "c", }),
                        }
                    })
                end
            },

[twiddli]

My bad. I got it working. Think I'm starting to get the hangs of things now.

{
                'hrsh7th/nvim-cmp',
                config = function()
                    local cmp = require("cmp")
                    cmp.setup({
                        mapping = {
                            -- If nothing is selected (including preselections) add a newline as usual.
                            -- If something has explicitly been selected by the user, select it.
                            ["<Enter>"] = function(fallback)
                                -- Don't block <CR> if signature help is active
                                -- https://github.com/hrsh7th/cmp-nvim-lsp-signature-help/issues/13
                                if not cmp.visible() or not cmp.get_selected_entry() or cmp.get_selected_entry().source.name == 'nvim_lsp_signature_help' then
                                    fallback()
                                else
                                    cmp.confirm({
                                        -- Replace word if completing in the middle of a word
                                        -- https://github.com/hrsh7th/nvim-cmp/issues/664
                                        behavior = cmp.ConfirmBehavior.Replace,
                                        -- Don't select first item on CR if nothing was selected
                                        select = false,
                                    })
                                end
                            end,
                            ["<Tab>"] = cmp.mapping(function(fallback)
                                -- This little snippet will confirm with tab, and if no entry is selected, will confirm the first item
                                if cmp.visible() then
                                    local entry = cmp.get_selected_entry()
                                    if not entry then
                                        cmp.select_next_item({ behavior = cmp.SelectBehavior.Select })
                                    else
                                        cmp.confirm()
                                    end
                                else
                                    fallback()
                                end
                            end, { "i", "s", "c", }),
                        }
                    })
                end
            }, 

[fitrh]

It seems that your <CR> is mapped to cmp.confirm({ select = true }), if so,
then you can remap <CR> to cmp.mapping.confirm({ select = false }),
you can also set

completion = {
    completeopt = "menu,menuone,noinsert,noselect",
},

To avoid auto selection.

[Sma1lboy]

Late comment, but try my config

 ["<Tab>"] = cmp.mapping(function(fallback)
      if cmp.visible() then
        local entries = cmp.get_entries()
        cmp.select_next_item({ behavior = cmp.SelectBehavior.Select })

        if #entries == 1 then
          cmp.confirm()
        end
      else
        fallback()
      end
    end, { "i", "s" }),

[sinkr]

This worked beautifully, thank you!

[jsikstro]

Perfect.

[rew1nter]

I was googling how to tab complete with nvim-cmp and got here. Both of these tab completions are amazing.
Thank you @twiddli @Sma1lboy

[GeoDaoyu]

it do not work when I use the same config from @twiddli.
but when I change 'config' to 'opts', it worked.
here is my whole code:

return {
  {
    "L3MON4D3/LuaSnip",
    keys = function()
      return {}
    end,
  },
  {
    "hrsh7th/nvim-cmp",
    opts = function()
      local cmp = require("cmp")
      cmp.setup({
        mapping = {
          ["<Tab>"] = cmp.mapping(function(fallback)
            if cmp.visible() then
              local entry = cmp.get_selected_entry()
              if not entry then
                cmp.select_next_item({ behavior = cmp.SelectBehavior.Select })
              else
                cmp.confirm()
              end
            else
              fallback()
            end
          end, { "i", "s", "c" }),
        },
      })
    end,
  },
}

I dont know the diff of 'config' and 'opts', but thanks this issue and guys.