Skip to content

Commit

Permalink
Merge pull request GUDHI#1161 from VincentRouvreau/fix_pip_ci
Browse files Browse the repository at this point in the history
New docker image build should fix libc issues
  • Loading branch information
VincentRouvreau authored Dec 10, 2024
2 parents cd6dd97 + 87e7088 commit 350a3db
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
12 changes: 3 additions & 9 deletions .github/workflows/pip-build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,14 @@ name: pip build linux

on: [push, pull_request]

# Temporary workaround to allow node16
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

jobs:
build:
name: build pip wheel
runs-on: ubuntu-latest
# cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip
container: gudhi/pip_for_gudhi:2024.10.02
container: gudhi/pip_for_gudhi:2024.12.02
steps:
# Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: Build wheel for Python 3.9
Expand All @@ -37,8 +32,7 @@ jobs:
$PYTHON39/bin/python -m pytest -v src/python/test/test_cubical_complex.py
$PYTHON39/bin/python -m pytest -v src/python/test/test_rips_complex.py
- name: Upload linux python wheel
# Should use actions/upload-artifact@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: linux python wheel
path: build_39/src/python/wheelhouse/*.whl
5 changes: 2 additions & 3 deletions .github/workflows/pip-packaging-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ jobs:
name: build pip wheel
runs-on: ubuntu-latest
# cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip
container: gudhi/pip_for_gudhi:2024.10.02
container: gudhi/pip_for_gudhi:2024.12.02
steps:
# Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
# Python 3.8 specific case where NumPy 2.x will not be supported
Expand Down

0 comments on commit 350a3db

Please sign in to comment.