small fixes

hschreiber · Jan 15, 2024 · 499972c · 499972c
1 parent cf880bf
commit 499972c
Show file tree

Hide file tree

Showing 5 changed files with 256 additions and 31 deletions.
diff --git a/src/Persistence_matrix/include/gudhi/Persistence_matrix/base_swap.h b/src/Persistence_matrix/include/gudhi/Persistence_matrix/base_swap.h
@@ -12,7 +12,6 @@
 #define PM_BASE_SWAP_H
 
 #include <utility>	//std::swap, std::move & std::exchange
-#include <vector>
 
 namespace Gudhi {
 namespace persistence_matrix {

diff --git a/src/Persistence_matrix/include/gudhi/Persistence_matrix/overlay_position_to_id_index.h b/src/Persistence_matrix/include/gudhi/Persistence_matrix/overlay_position_to_id_index.h
@@ -280,7 +280,7 @@ template<class Matrix_type, class Master_matrix_type>
 inline typename Position_to_id_indexation_overlay<Matrix_type,Master_matrix_type>::Row_type &
 Position_to_id_indexation_overlay<Matrix_type,Master_matrix_type>::get_row(index rowIndex)
 {
-	return matrix_.get_row(matrix_.get_pivot(columnPositionToID_[rowIndex]));		//TODO: ???
+	return matrix_.get_row(matrix_.get_pivot(columnPositionToID_[rowIndex]));		//necessary because there can be a difference between the id used for the positioning and the id used for the simplex if the user used its own ids instead of id = initial position
 }
 
 template<class Matrix_type, class Master_matrix_type>

diff --git a/src/Persistence_matrix/include/gudhi/Persistence_matrix/ru_vine_swap.h b/src/Persistence_matrix/include/gudhi/Persistence_matrix/ru_vine_swap.h
@@ -326,7 +326,6 @@ inline bool RU_vine_swap<Master_matrix>::_positive_vine_swap(index index)
 		_positive_transpose(index);
 		return true;
 	}
-
 	return false;
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     		_positive_transpose(index);
     		return true;
     	}
     	return false;
     }
@@ Expand Down @@