Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 회원 생성의 책임을 회원 서비스로 이동한다. #91

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

hseong3243
Copy link
Owner

작업 내용

  • 회원 생성의 책임을 인증 서비스에서 새롭게 만든 회원 서비스로 이동하였습니다.
  • 패스워드 인코더 인터페이스를 회원 패키지로 이동하였습니다.

@hseong3243 hseong3243 self-assigned this Apr 17, 2024
@hseong3243 hseong3243 added the Refactor 프로젝트 구조 및 코드를 개선합니다. label Apr 17, 2024
Copy link

Test Results

187 tests  ±0   187 ✅ ±0   3s ⏱️ ±0s
 54 suites +1     0 💤 ±0 
 54 files   +1     0 ❌ ±0 

Results for commit 85299a8. ± Comparison against base commit 30a299c.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
com.seong.shoutlink.domain.auth.controller.AuthControllerTest ‑ 성공: 회원 등록 api 호출
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [1] invalidPassword=asdf
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [1] validPassword=asdf123!
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [2] invalidPassword=asdf1234
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [2] validPassword=asdfasdf12341234!@#$
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [3] invalidPassword=asdf!@#$
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [4] invalidPassword=1234!@#$
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [5] invalidPassword=a1!
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ [6] invalidPassword=thisisovertwentycharacters!@#$123
com.seong.shoutlink.domain.auth.service.AuthServiceTest$CreateMemberTest ‑ 성공: 회원 생성 이벤트 발행함
…
com.seong.shoutlink.domain.member.controller.MemberControllerTest ‑ 성공: 회원 등록 api 호출
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [1] invalidPassword=asdf
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [1] validPassword=asdf123!
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [2] invalidPassword=asdf1234
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [2] validPassword=asdfasdf12341234!@#$
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [3] invalidPassword=asdf!@#$
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [4] invalidPassword=1234!@#$
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [5] invalidPassword=a1!
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ [6] invalidPassword=thisisovertwentycharacters!@#$123
com.seong.shoutlink.domain.member.service.MemberServiceTest$CreateMemberTest ‑ 성공: 회원 생성 이벤트 발행함
…

@hseong3243 hseong3243 merged commit b845608 into main Apr 17, 2024
2 checks passed
@hseong3243 hseong3243 deleted the refactor/#90-merge-member-auth branch April 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 프로젝트 구조 및 코드를 개선합니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: 회원 생성의 책임을 회원 서비스로 이동한다.
1 participant