-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array destructor #14
base: master
Are you sure you want to change the base?
Array destructor #14
Conversation
Thanks, I'll take a look. Note that it should be exercised for |
@hsutter, the registration of destructors is done in So, right now,
I think option 1 would be space and time inefficient since we'll have a lot more |
@FatihBAKIR Actually it is beneficial, in the intended use case is |
Thanks again for this PR. For now I'm waiting for feedback and bug reports from actual use of the library, and deferring enhancements and optimizations until then but keeping them in the backlog. |
I've implemented the array destructor storage compaction with support for merging and splitting w.r.t. the comment on deferred_heap.h:77.
Although I've implemented the merging when a new object or array is added just after another array by incrementing the count instead of pushing another
array_destructor
,deferred_heap
never allocates two blocks consecutively (thestart
block in thegpage
), therefore, such a case never happens.