Большие перемены (часть 1) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ваш пулреквест опубликован. Посмотреть можно здесь |
…м дата окончания и наоборот
|
Ваш пулреквест опубликован. Посмотреть можно здесь |
|
Ваш пулреквест опубликован. Посмотреть можно здесь |
aimenin
reviewed
Oct 16, 2024
| 'id': `${id }4c3e4e6-9053-42ce-b747-e281314baa31`, | ||
| 'title': `Upgrade ${ id}`, | ||
| 'price': getRandomNumber(19,499) | ||
| 'id': nanoid(), |
There was a problem hiding this comment.
так вот здесь чуть чуть не понял, а как ты мапишь потом по id, если они у тебя рандомно генерятся?
|
|
||
| return Array.from(new Map(mergedEvents.map((event) => [event.id, event])).values()); | ||
| }; | ||
| const EVENTS_COUNT = 5; |
There was a problem hiding this comment.
я бы вынес в файл с константами, но если это только для моков - то можно оставить здесь, главное потом не забыть удалить
| evt.preventDefault(); | ||
|
|
||
| const offerId = evt.currentTarget.dataset.offerId; | ||
| const offers = new Map (this._state.offers); |
There was a problem hiding this comment.
не очень понял зачем здесь делать новую мапу из стейта?
| }; | ||
|
|
||
| removeEventListeners() { | ||
| this.#rollupButton.removeEventListener('click', this.#clickHandler); | ||
| this.#formElement.removeEventListener('submit', this.#submitHandler); | ||
| } | ||
|
|
||
| #setDatepicker() { |
There was a problem hiding this comment.
насколько я помню, экземпляр datepicker мы делаем на уровне презентера, и передаем уже сюда
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Большие перемены (часть 1)