Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Пришёл, увидел, загрузил (часть 1) #9

Merged
merged 14 commits into from
Oct 23, 2024

Conversation

Talurion
Copy link
Contributor

@Talurion Talurion commented Oct 22, 2024

Copy link

Ваш пулреквест опубликован. Посмотреть можно здесь

github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
@keksobot keksobot changed the title Module8 финальный Пришёл, увидел, загрузил (часть 1) Oct 23, 2024
@keksobot keksobot merged commit 60d0b17 into htmlacademy-ecmascript:master Oct 23, 2024
2 checks passed
Copy link

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа!

import BoardPresenter from './presenter/board-presenter.js';
import FilterPresenter from './presenter/filter-presenter.js';
import NewAddEventButtonView from './view/new-add-event-button-view.js';
import EventsApiService from './events-api-service.js';

const AUTHORIZATION = 'Basic 357082111.1703690932';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в файлик с константами, либо в файл с api


#generateDefaultEvent = (offersMap, defaultType) => {
const defaultOffers = offersMap.get(defaultType) || null;
const defaultEvent = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

такой ивент можно в константу вынести

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants