Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Время разбивать камни #3

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

reking06
Copy link

@reking06 reking06 commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

Ваш пулреквест опубликован. Посмотреть можно здесь

github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@keksobot keksobot changed the title 1.24 modulation Время разбивать камни Sep 2, 2024
Copy link

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа, только передай контейнеры в пресентер

@@ -0,0 +1,5 @@
import GlobalPresenter from './presenter/global-presenter.js';

const globalPresenter = new GlobalPresenter();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

здесь нам нужно передать в Presenter main container и events container, куда мы уже будем рендерить наши элементы


constructor() {
this.pageHeader = document.querySelector('.page-header');
this.tripMain = this.pageHeader.querySelector('.trip-main');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот эти параметры мы передаем снаружи

@keksobot keksobot merged commit a0a7a00 into htmlacademy-ecmascript:master Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants