Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Шаблонизируй это #8

Merged
merged 13 commits into from
Sep 25, 2024

Conversation

Phoenix8483
Copy link
Contributor

@Phoenix8483 Phoenix8483 commented Sep 23, 2024

@keksobot keksobot changed the title Module2 task1 Шаблонизируй это Sep 23, 2024
Copy link

Ваш пулреквест опубликован. Посмотреть можно здесь

github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
@@ -1,7 +1,7 @@
import { getRandomPoint } from '../mock/points.js';
import { mockOffers } from '../mock/offers.js';
import { mockDestinations } from '../mock/destination.js';
const POINT_COUNT = 3; //Количество поинтов (сколько раз отрисуется поинт getRandomPoint)
const POINT_COUNT = 4; //Количество поинтов (сколько раз отрисуется поинт getRandomPoint)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот такие комментарии нужно переносить в названия идентификаторов. То есть в данном случае декларировать ее как POINT_COUNT_FOR_RENDER, RENDERING_POINT_COUNT.

const { basePrice, type, isFavorite} = point;
const typeName = type[0].toUpperCase() + type.slice(1, type.length);

const createEventOfferTemplate = (title, price) => (`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

шаблоны нужно будет поправить

@DenisLopatin DenisLopatin merged commit c4b4101 into htmlacademy-ecmascript:master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants