Шаблонизируй то #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlSudar
reviewed
Sep 28, 2024
src/main.js
Outdated
| @@ -18,6 +22,10 @@ const listPresenter = new ListPresenter({ | |||
| offersTripModel, | |||
| }); | |||
|
|
|||
| const filters = generateFilter(); | |||
|
|
|||
| render(new TripFiltersFormView({filters}), tripFiltersElement); | |||
There was a problem hiding this comment.
Мне кажется лучше рендерить фильтры внутри ListPresenter, т.к. список точек маршрутра и фильтрация - это взаимосвязанные вещи
AlSudar
reviewed
Sep 28, 2024
src/presenter/list-presenter.js
Outdated
|
|
||
| /** Рендерим кнопки сортировки */ | ||
| this.#renderSort(); |
There was a problem hiding this comment.
Лучше вынести из этого метода #renderSort(); и render(new SectionTripInfoView({allDestinations: this.#destinations , allPoints: this.#listPoints}), tripMain, RenderPosition.AFTERBEGIN); . В будущем могут возникнуть ситуации в которых нам надо перерендерить список, но не перерендеривать эти два элемента. В целом лучше разделять на разные методы рендеры разных кусков нашего приложения
…в отдельный презентер
|
Ваш пулреквест опубликован. Посмотреть можно здесь |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Шаблонизируй то