fix excessive escaping in node package manager arguments

htmlburger · Oct 28, 2018 · 6ad1bfc · 6ad1bfc
1 parent b1b2595
commit 6ad1bfc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
     "name": "htmlburger/wpemerge-cli",
-    "version": "0.10.1",
+    "version": "0.11.1",
     "description": "CLI tool for WP Emerge.",
     "type": "library",
     "license": "GPL-2.0-only",

diff --git a/src/NodePackageManagers/Npm.php b/src/NodePackageManagers/Npm.php
@@ -38,7 +38,7 @@ public function installed( $directory, $package ) {
 	 */
 	public function install( $directory, OutputInterface $output, $package, $version = null, $dev = false ) {
 		$command = 'npm install ' .
-			'"' . escapeshellarg( $package ) . ( $version !== null ? '@' . $version : '' ) . '"' .
+			'"' . $package . ( $version !== null ? '@' . $version : '' ) . '"' .
 			( $dev ? ' --only=dev' : '' );
 
 		App::liveExecute( $command, $output, $directory );

diff --git a/src/NodePackageManagers/Yarn.php b/src/NodePackageManagers/Yarn.php
@@ -32,7 +32,7 @@ public function installed( $directory, $package ) {
 	 */
 	public function install( $directory, OutputInterface $output, $package, $version = null, $dev = false ) {
 		$command = 'yarn add ' .
-			'"' . escapeshellarg( $package ) . ( $version !== null ? '@' . $version : '' ) . '"' .
+			'"' . $package . ( $version !== null ? '@' . $version : '' ) . '"' .
 			( $dev ? ' --dev' : '' );
 
 		App::liveExecute( $command, $output, $directory );