New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_sample_list方法会遍历2次manifest文件 #12

Open

sleepfin opened this issue Sep 21, 2019 · 0 comments

sleepfin commented Sep 21, 2019

modelarts-dataset-sdk/huaweicloud-sdk-python-modelarts-dataset/modelarts/manifest.py

Line 26 in 40bf541

    
           def get_sample_list(manifest_path, task_type, exactly_match_type=False, access_key=None,

在set_sample_list方法里，parse_manifest会对manifest文件的所有lines遍历一遍
然后又对sample_list遍历了一遍

在百万级以上的数据集上，manifest文件会比较大，遍历2次会很慢，希望优化。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment