Merge pull request #745 from hubmapconsortium/Derek-Furst/exclude-res…

…ults

Fixed a bug where datasets within a public collection were not being …

src/app.py

@@ -715,6 +715,13 @@ def get_entity_by_id(id):
         # Response with the dict
         if public_entity and not user_in_hubmap_read_group(request):
             final_result = schema_manager.exclude_properties_from_response(fields_to_exclude, final_result)
+        if normalized_entity_type == 'Collection':
+            for i, dataset in enumerate(final_result.get('datasets')):
+                if _get_entity_visibility(normalized_entity_type='Dataset', entity_dict=dataset) != DataVisibilityEnum.PUBLIC or user_in_hubmap_read_group(request):
+                    # If the dataset is non-public, or if the user has read-group access, there is no need to remove fields, continue to the next dataset
+                    continue
+                dataset_excluded_fields = schema_manager.get_fields_to_exclude('Dataset')
+                final_result.get('datasets')[i] = schema_manager.exclude_properties_from_response(dataset_excluded_fields, dataset)
         return jsonify(final_result)
 
 """